Tickets/dm 2188 -- Make a.net solver callable in new astrometry task. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed Astrometry to ANetAstrometryBasicTask and renamed the module accordingly. Renamed MeasAstromConfig to ANetAstrometryBasicConfig and moved it into the same file. Stopped importing the module astrom into lsst.meas.astrom (its symbols were and still are imported into lsst.meas.astrom). Modified ANetAstrometryBasicTask to use LoadAstrometryNetObjectsTask, thus getting rid of a lot of duplicate code. Modified LoadAstrometryNetObjectsTask to use the new interface: loadPixelBox and loadSkyCircle instead of loadObjectsInBBox and _loadObjectsInCircle. Updated the unit tests accordingly. Removed deprecated method ANetAstrometryBasicTask.getCatalogFilterName. Removed redundant unit tests. Removed unused imports from unit tests. Bug fix
Modified getCatalog and getCatalogImpl to always return the new schema.
Update tests/testFitTanSipWcsTask.py to test the on-sky scatter.
ANetBasicAstrometryTask cleanups:
- removed a lot of code that was duplicated in refObjLoader
- make it a Task, since it was acting just like one anyway;
one side effect is that the constructor no longer takes logLevel as an argument,
so I had to change a few unit tests acccordingly.
- use bbox as an argument instead of x0, y0, imageSize
- _getImageParams returns wcs (as it surely must have done earlier,
since wcs was an argument)
- standardize formatting of config parameters
- clean up some of the documentation
Also set ANetBasicAstrometryConfig.badFlags to a useful default,
though naturally it is one that requires the new source table schema.
Test cleanups:
- Updated unit tests so all tables have the new schema, including
a CR flag that was missing (though it is alway set False).
- One set of test data was in examples, rather than tests; I moved that
and updated the one example that used it.
- Removed several test data files that were not being used
- Added a test of AstrometryTask for config.forceKnownWcs True
- Updated unit tests to handle log level differently (since ordinary tasks
do not accept that as a constructor argument).
Fix a bug in AstrometryTask triggered by forceKnownWcs
AstrometryTask's iteration was incorrect if forceKnownWcs True,
and a log message would raise an exception because scatterOnSky unknown.
Also I adde config parameter maxIter to control iteration.
Set ANetBasicAstrometryConfig.badFlags to a useful default
Add base_PixelFlags_flag_crCenter to test source catalogs
Update test catalogs to include field base_PixelFlags_flag_crCenter
(since it is used, by default, for astrometry).
Also move some test files from examples
and update the way tests find data files.
Remove a few unused test data files
Fix a bug with forceKnownWcs and test that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.