Set distance field in matches in matcher and WCS fitter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatchOptimisticBTask and FitTanSipWcsTask both now set the distance field of their match lists. Further improvements: - FitTanSipWcsTask updates the reference centroid and source coord in the match list even if the reference catalog or source catalog are not provided. - FitTanSipWcsTask.updateRefCentroids and updateSourceCoords now can handle any collection of reference objects or sources. - Updated unit tests to check that the distance field of matches is correctly set. More work on setting distance in match lists
Added missing files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatchOptimisticBTask and FitTanSipWcsTask both now set the distance field
of their match lists. Further improvements:
even if the reference catalog or source catalog are not provided.
any collection of reference objects or sources.
More work on setting distance in match lists