DM-9812: Clean up outputs from CharacterizeImageTask and CalibrateTask #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
reviewed
Mar 21, 2017
| __all__ = ["matchesToCatalog"] | ||
|
|
||
| def matchesToCatalog(matches, matchMeta=None): | ||
| """Write matches as a Catalog |
There was a problem hiding this comment.
This could be more descriptive. It doesn't actually write. How about "Join reference and source catalogs to associative* match list"
- your favorite of associative, cross-reference, junction.
yalsayyad
reviewed
Mar 21, 2017
|
|
||
| __all__ = ["matchesToCatalog"] | ||
|
|
||
| def matchesToCatalog(matches, matchMeta=None): |
There was a problem hiding this comment.
I find your module name more descriptive than this function name. How about "denormalizeMatches"? Or denormalizeRefMatch?or joinReferenceSource? (since in database lingo, I'd say this is creating a materialized view of the joined reference and source cat dimensions.)
PaulPrice
force-pushed
the
tickets/DM-9812
branch
4 times, most recently
from
57892fc
to
73531ca
Compare
This produces persisted catalogs that are easier to read, even though they take more space.
PaulPrice
force-pushed
the
tickets/DM-9812
branch
from
73531ca
to
7444972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces persisted catalogs that are easier to read,
even though they take more space.