DM-4639: modernize afw code and reduce doxygen errors #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
approved these changes
Apr 25, 2017
| @@ -252,7 +252,7 @@ CreateWcsWithSip<MatchT>::_calculateForwardMatrices() | |||
|
|
|||
| afwGeom::Point2D crval = _getCrvalAsGeomPoint(); | |||
|
|
|||
| _linearWcs = afwImg::Wcs::Ptr( new afwImg::Wcs(crval, crpix, CD)); | |||
| _linearWcs = std::shared_ptr<afwImg::Wcs>( new afwImg::Wcs(crval, crpix, CD)); | |||
kfindeisen
force-pushed
the
tickets/DM-4639
branch
from
52d0a38
to
70abcaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-4639 requires that
afwcomponents no longer have type membersPtrandConstPtrrepresenting shared pointers to those types. This is a breaking API change that requires changes to downstream code.For clarity, no unnecessary changes changes were made to this package, not even a
clang-formatpass.