Add calib_astrometryUsed flag to AstrometryTask #71
Conversation
|
I still don't see where the |
tests/testAstrometryTask.py
Outdated
| config = AstrometryTask.ConfigClass() | ||
| config.wcsFitter.order = 2 | ||
| config.wcsFitter.numRejIter = 0 | ||
| # schema must be passed to the solver task constructor |
There was a problem hiding this comment.
only one space after hash.
tests/testAstrometryTask.py
Outdated
| sourceCat=sourceCat, | ||
| exposure=self.exposure, | ||
| ) | ||
| # check that the used flag is set the right number of times |
tests/testAstrometryTask.py
Outdated
| # check that the used flag is set the right number of times | ||
| count = 0 | ||
| flagKey = sourceCat.getSchema().find("calib_astrometryUsed").key | ||
| for source in sourceCat: |
There was a problem hiding this comment.
I think this for loop can be just count = (sourceCat['calib_astrometryUsed']==True).sum()
There was a problem hiding this comment.
I think that I originally I tried this, or a slight variant, as I did in the photCal test. But I got 'Record data is not contiguous in memory. ' error. I did not stop to explore it, but just changed it to a loop.
Let me know if you think it matters. Since I built this out of a test which already existed, I didn't particularly want to mess around with it.
There was a problem hiding this comment.
I'm surprised that it won't work in this particular context, but I haven't tried. Since it's in the test code, I guess it's fine.
|
I also removed the import random as per Lauren comment. It was used by the reserve candidates code, which was later removed. |
pgee2000
force-pushed
the
tickets/DM-9050
branch
2 times, most recently
from
c92b862
to
ee69e0b
Compare
Previous merge was accidental. The actual changes are here. Includes a quick test which only shows that the task is able to write to the schema and sources table.
Previous merge was accidental. The actual changes are here.
Includes a quick test which only shows that the task is able
to write to the schema and sources table.