DM-10931: Removed print Fix variable name bug and remove print statements in matchPessimisticB. and fixed distances_rad name. #73
Conversation
| @@ -273,7 +273,7 @@ def match(self, source_array, n_check, n_match, n_agree, | |||
| # Initialize output struct. | |||
| output_match_struct = pipeBase.Struct( | |||
| match_ids=[], | |||
| distances=[], | |||
| distances_rad=[], | |||
There was a problem hiding this comment.
Also update the numpy docs above to match: the output is distances_rad instead of distances
| @@ -505,7 +503,6 @@ def _doMatch(self, refCat, sourceCat, wcs, refFluxField, numUsableSources, | |||
| dist_cut_arcsec = np.max( | |||
| (2 * wcs.pixelScale().asArcseconds(), | |||
| clipped_dist_arcsec, maxMatchDistArcSec)) | |||
| print("Dist cut", dist_cut_arcsec, "arcsec") | |||
There was a problem hiding this comment.
If you think any of these print statements may be of interest to somebody then I strongly suggest you make these log statements at some suitable verbosity. INFO is usually printed. TRACE is the next step in verbosity (not normally printed), then DEBUG is even more verbose. Here is an example showing TRACE. I provide the data as a separate argument, so the message is only formatted if it is to be printed, though that is a bit silly here because computation of max will likely be more expensive than the formatting:
self.log.trace("max distance = %s arcsec", distances_arcsec.max())
There was a problem hiding this comment.
These where more for me to check what was going on in the unittest when I was trying to update the code. The useful information about matching is already stored in the debug logger.
Updated docstring for match method.
morriscb
force-pushed
the
tickets/DM-10931
branch
from
23f342d
to
6b27dd1
Compare
No description provided.