DM-13243: PhotoCalTask must only match with DirectMatchTask #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Feb 1, 2018
| refObjLoader = ConfigurableField(target=LoadIndexedReferenceObjectsTask, doc="Load reference objects") | ||
| class DirectMatchConfigWithoutLoader(Config): | ||
| """Configuration for DirectMatchTask when an already-initialized | ||
| refObjLoader will be passed to this task. """ |
There was a problem hiding this comment.
Excess space in docstring.
| matchRadius = Field(dtype=float, default=0.25, doc="Matching radius, arcsec") | ||
| sourceSelection = ConfigurableField(target=ScienceSourceSelectorTask, | ||
| doc="Selection of science sources") | ||
| referenceSelection = ConfigurableField(target=ReferenceSourceSelectorTask, | ||
| doc="Selection of reference sources") | ||
|
|
||
| class DirectMatchConfig(DirectMatchConfigWithoutLoader): |
There was a problem hiding this comment.
Two lines between classes, please.
ctslater
force-pushed
the
tickets/DM-13243
branch
from
71faa0f
to
57ff94b
Compare
This config can be used when DirectMatchTask will be supplied a refObjLoader at initialization, and thus it need not accept a configuration for its own loader. Using the DirectMatchConfig in this situation is permissible (to maintain compatibility) but the refObjLoader settings will be silently ignored.
ctslater
force-pushed
the
tickets/DM-13243
branch
from
57ff94b
to
cf9427f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra DirectMatch config with no refObjLoader.