DM-11162: Replace all use of Coord and subclasses with SpherePoint #81
Conversation
also use averageSpherePoint instead of averageCoord
tests/test_fitTanSipWcsHighOrder.py
Outdated
| self.tanWcs = afwGeom.makeSkyWcs(metadata) | ||
| self.tanWcs = afwGeom.makeSkyWcs(crpix=self.crPix, | ||
| crval=afwGeom.SpherePoint(215.5, 53.0, afwGeom.degrees), | ||
| cdMatrix=afwGeom.makeCdMatrix(scale=5.1e-5*afwGeom.degrees, |
There was a problem hiding this comment.
Is there a need to simplify the cdMatrix here?
There was a problem hiding this comment.
I don't understand the question. The primary changes is to use makeSkyWcs(crpix, ...) instead of makeSkyWcs(metadata), saving the hassle of creating a bunch of FITS-WCS metadata. makeSkyWcs(crpix, ...) requires a CD matrix and makeCdMatrix is the easiest way I know of to make one.
There was a problem hiding this comment.
Yeah, sorry I wasn't explicit. Your new cdMatrix has only a scale and rotation. The previous cdMatrix looks like it is more complicated with some shear.
There was a problem hiding this comment.
Good point. I missed the difference between CD2_1 and CD1_2. I'll restore the original values. I've never seen a CD matrix like that before. I wonder if it was intentional.
| np.random.uniform(low=bbox.getMinX(), high=bbox.getMaxX()), | ||
| np.random.uniform(low=bbox.getMinY(), high=bbox.getMaxY()) | ||
| np.random.uniform(low=bbox.getMinY(), high=bbox.getMaxY()), |
There was a problem hiding this comment.
It is not necessary but it is good Python style because it allows reordering elements and removing elements safely. (A trailing comma on the last entry is necessary only when the tuple has 1 element.)
Create WCS using crpix, etc. instead of setting FITS metadata. The result is shorter and easier to read. Note that the initial WCS data is for ICRS instead of FK5, but this has no effect on the tests.
r-owen
force-pushed
the
tickets/DM-11162
branch
from
1c519b1
to
4169de5
Compare
No description provided.