DM-8828: Support proper motions in reference catalogs #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
reviewed
Jun 7, 2018
python/lsst/meas/astrom/ref_match.py
Outdated
| """ | ||
| exposureInfo = exposure.getInfo() | ||
| filterName = exposureInfo.getFilter().getName() or None | ||
| if filterName == "_unknown_": | ||
| filterName = None | ||
| epoch = None | ||
| if exposure.getInfo().hasVisitInfo(): | ||
| epoch = exposure.getInfo().getVisitInfo().getDate().get() |
There was a problem hiding this comment.
Here is another place where returning a DateTime instead of a float would, I think, be an improvement.
| @@ -92,22 +92,23 @@ def __init__(self, butler=None, refObjLoader=None, **kwargs): | |||
| self.makeSubtask("sourceSelection") | |||
| self.makeSubtask("referenceSelection") | |||
|
|
|||
| def run(self, catalog, filterName=None): | |||
| def run(self, catalog, filterName=None, epoch=None): | |||
There was a problem hiding this comment.
Pease accept epoch as a DateTime instead of a float in MJD TAI, in order to avoid an obvious source of errors (incorrect system or scale).
parejkoj
reviewed
Jul 3, 2018
| """ | ||
| exposureInfo = exposure.getInfo() | ||
| filterName = exposureInfo.getFilter().getName() or None | ||
| if filterName == "_unknown_": | ||
| filterName = None | ||
| epoch = None | ||
| if exposure.getInfo().hasVisitInfo(): |
There was a problem hiding this comment.
Why would an exposure not have VisitInfo?
There was a problem hiding this comment.
It is easy to make an exposure without VisitInfo so it is not safe to assume there is one. That said, it is more likely to happen for unit test than in real life so I suppose we could raise an exception at this point.
r-owen
force-pushed
the
tickets/DM-8828
branch
2 times, most recently
from
feb3c39
to
dfeaf43
Compare
SimonKrughoff
approved these changes
Aug 31, 2018
r-owen
force-pushed
the
tickets/DM-8828
branch
2 times, most recently
from
976dce5
to
be05087
Compare
Mainly this consists of getting the epoch (TAI MJD) of the exposure into the catalog loader.
r-owen
force-pushed
the
tickets/DM-8828
branch
from
be05087
to
60c257d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly this consists of getting the epoch (TAI MJD) of the exposure into
the catalog loader.