Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13905: Change SpherePoint.getVector to return a sphgeom UnitVector3d #83

Merged
merged 8 commits into from Apr 26, 2018

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Apr 25, 2018

No description provided.

@r-owen r-owen force-pushed the tickets/DM-13905 branch 2 times, most recently from 6d2b0ec to 009cff7 Compare April 26, 2018 14:53
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -33,7 +32,7 @@ def getAllKeys(opt, inButler):
if not len(opt.visit):
# Grab all available visits.
print('Grabbing all available visits...')
#visits = inButler.queryMetadata('visitim', 'visit')
# visits = inButler.queryMetadata('visitim', 'visit')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better fix is to just delete this line.

@r-owen r-owen merged commit d2e5f28 into master Apr 26, 2018
@ktlim ktlim deleted the tickets/DM-13905 branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants