Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-15046: When comparing angles in MatchPessimisticB, make sure all vectors are plane projected #94

Merged
merged 4 commits into from
Jul 18, 2018
Merged

DM-15046: When comparing angles in MatchPessimisticB, make sure all vectors are plane projected #94

merged 4 commits into from
Jul 18, 2018

Commits on Jul 12, 2018

  1. Plane project vectors for rotation test.

    @morriscb
    morriscb committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    d3f2304 View commit details
    Browse the repository at this point in the history

  2. Plane project delta vectors in spoke test

    @morriscb
    morriscb committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    d4fe5c7 View commit details
    Browse the repository at this point in the history

  3. Move projection calculations for efficiency. 

    Remove unnecessary inputs from method call signatures.

Fix call to _test_spoke
    @morriscb
    morriscb committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    972fddb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. Respond to reviewer. 

    Fix variable name typo.
Clarify code doc string.
reword variable name.

Change var names and comment text.
    @morriscb
    morriscb committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    6fd786d View commit details
    Browse the repository at this point in the history