Skip to content

Commit

Permalink
Default to copying all data on transformation
Browse files Browse the repository at this point in the history
As requested in code review.
  • Loading branch information
jdswinbank committed Feb 26, 2015
1 parent 5dfdbad commit b8ff194
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions python/lsst/meas/base/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

from .baseLib import *
from .noiseReplacer import *
from .transforms import NullTransform
from .transforms import PassThroughTransform

# Exceptions that the measurement tasks should always propagate up to their callers
FATAL_EXCEPTIONS = (MemoryError, FatalAlgorithmError)
Expand Down Expand Up @@ -274,10 +274,10 @@ def getTransformClass():
measurement quantities to calibrated units. Calibrated data is then
provided in a separate output table.
By default, we assume that no transformation is appropriate, and
therefore return NullTransform.
By default, we copy everything from the input to the output without
transformation.
"""
return NullTransform
return PassThroughTransform


class SourceSlotConfig(lsst.pex.config.Config):
Expand Down
2 changes: 1 addition & 1 deletion tests/testTransform.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def testApplyCppTransform(self):
class AlgorithmConfigurationTestCase(utilsTests.TestCase):
def testDefaultTransform(self):
"""By default, we perform no transformations"""
self.assertEqual(measBase.BasePlugin.getTransformClass(), measBase.NullTransform)
self.assertEqual(measBase.BasePlugin.getTransformClass(), measBase.PassThroughTransform)

def testWrapAlgorithm(self):
"""Test that the appropriate transform is provided for wrapped algorithms"""
Expand Down

0 comments on commit b8ff194

Please sign in to comment.