DM-10957: Add measurement algorithm for point sources on fluff #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
reviewed
Feb 20, 2018
src/LocalBackground.cc
Outdated
| assert(imageValues.getNumElements() == maskValues.getNumElements()); // constructed from the same spans | ||
| auto maskIter = maskValues.begin(); | ||
| for (auto imageIter = imageValues.begin(); imageIter != imageValues.end(); ++imageIter, ++maskIter) { | ||
| if (*maskIter & maskVal) continue; |
There was a problem hiding this comment.
Is there a better name for maskVal, to distinguish it from maskValues? ignoredPixelBitmask or badPixelBitmask?
I think the comparison reads a little easier if its if (...) != 0 continue;. Or
if (... == 0) {
values.push_back(...)
}
| LSST_CONTROL_FIELD(annulusOuter, float, | ||
| "Outer radius for background annulus as a multiple of the PSF sigma"); | ||
| LSST_CONTROL_FIELD(bgRej, float, | ||
| "Rejection threshold for background measurement"); |
There was a problem hiding this comment.
Mention this is in units of standard deviations?
| LSST_CONTROL_FIELD(bgRej, float, | ||
| "Rejection threshold for background measurement"); | ||
| LSST_CONTROL_FIELD(bgIter, int, | ||
| "Number of iterations for background measurement"); |
There was a problem hiding this comment.
number of sigma-clipping iterations.
| // -*- lsst-c++ -*- | ||
| /* | ||
| * LSST Data Management System | ||
| * Copyright 2008-2017 AURA/LSST. |
There was a problem hiding this comment.
Might as well say 2018 in the boilerplates, fwiw.
Useful for subtracting a revised background (per pixel) estimate.
Some sources are superimposed on others, and so measurement of a small-scale background is helpful for getting the true flux measurement.
For both single-frame and forced measurement modes.
PaulPrice
force-pushed
the
tickets/DM-10957
branch
from
922cc3d
to
ac081cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.