meas_base Review for DM-420 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -499,7 +498,6 @@ MAKE_TWODG(afw::image::Image<float>); | |||
| MAKE_TWODG(afw::image::Image<double>); | |||
| MAKE_TWODG(afw::image::Image<int>); | |||
|
|
|||
| } // end anonymous namespace | |||
There was a problem hiding this comment.
I don't think there's any reason to remove the anonymous namespace here - I'm guessing this is a relic from when you had planned to make the {{twodg}} function itself public, rather than a wrapper (I like what you've done with the wrapper much better, but I think that means you can put the anonymous namespace back in).
|
One general note: I see that there's been another merge to master since you last rebased, and it was a fairly major ticket. You may want to rebase one more time before merging, just to make sure you can get any conflicts dealt with more easily. |
…rement Added classes to tests.py to manage running measurement on single algs and lists of algs. Moved Gaussian Centroid routines to a visible namespace DM-420 add fitCentroid static method to GaussianCentroidAlgorithm move files from meas_algorithms and convert to meas_base Changes to remove versionFlag0Mapper review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.