DM-14740: Stop using ndarray::EigenView indirectly in C++ code #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace it with ndarray::asEigenArray, which returns an Eigen::Map instead of an ndarray::EigenView
In all but one case the Eigen::Map was being used as a matrix, not an array, so make the maps matrices.
kfindeisen
approved these changes
Jun 18, 2018
| auto model = ndarray::asEigenMatrix(modelNdArray); | ||
| auto data = ndarray::asEigenMatrix(dataNdArray); | ||
| auto variance = ndarray::asEigenMatrix(varianceNdArray); | ||
| PsfPixel alpha = model.squaredNorm(); |
There was a problem hiding this comment.
Why are these asEigenMatrix rather than asEigenArray? The original code used asEigen<Eigen::ArrayXpr>.
There was a problem hiding this comment.
Because in almost all cases in the old code the array EigenView is used as a matrix by appending .matrix(). This eliminates all those calls to .matrix() at the expense of adding one call to .array(). See the changes below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.