DM-1364 set specific MeasurementError's for SdssCentroidAlgorithm #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +242,8 @@ void doMeasureCentroidImpl(double *xCenter, // output; x-position of object | |||
| double *sizeX2, double *sizeY2, // output; object widths^2 in x and y directions | |||
| double *peakVal, // output; peak of object | |||
| MaskedImageXy_locatorT mim, // Locator for the pixel values | |||
| double smoothingSigma // Gaussian sigma of already-applied smoothing filter | |||
| double smoothingSigma,// Gaussian sigma of already-applied smoothing filter | |||
There was a problem hiding this comment.
Should be a space after the ,
pgee2000
force-pushed
the
u/pgee/DM-1364
branch
from
2b642da
to
b896183
Compare
These new flags correspond to the errors in the original algorithm: not_at_maximum when the centroid is at a point lower than surround no_2nd_derivative when the 2nd derivative around the point is <= 0 almost_not_at_2nd_derivate when it is too small around the point
pgee2000
force-pushed
the
u/pgee/DM-1364
branch
from
b896183
to
6f11e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for review.