DM-17474: Convert ForcedPhotCcd and ForcedPhotCoadd into pipelineTasks. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
requested review from
natelust and
yalsayyad
and removed request for
natelust
yalsayyad
changed the title
yalsayyad
approved these changes
Jan 30, 2019
czwa
force-pushed
the
tickets/DM-17474
branch
from
a361322
to
7d32372
Compare
TallJimbo
reviewed
Jan 31, 2019
TallJimbo
reviewed
Jan 31, 2019
TallJimbo
reviewed
Jan 31, 2019
czwa
force-pushed
the
tickets/DM-17474
branch
2 times, most recently
from
e3d6ebd
to
8063393
Compare
The conversion of ForcedPhotCoadd was straightforward. ForcedPhotCcd required more handling, with duplicate operations in adjustArgsAndRun to work around Gen-2 butler methods in the source filtering and transformation code.
czwa
force-pushed
the
tickets/DM-17474
branch
from
8063393
to
3538faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion of ForcedPhotCoadd was straightforward. ForcedPhotCcd
required more handling, with duplicate operations in adjustArgsAndRun
to work around Gen-2 butler methods in the source filtering and
transformation code.