Tickets/DM-17757 Fix creating imports when saving config #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 15, 2019
| @@ -68,7 +68,7 @@ def fail(self, measRecord, error=None): | |||
| self.cpp.fail(measRecord, error.cpp if error is not None else None) | |||
|
|
|||
|
|
|||
| def wrapAlgorithmControl(Base, Control, module=2, hasMeasureN=False): | |||
| def wrapAlgorithmControl(Base, Control, module=None, hasMeasureN=False): | |||
There was a problem hiding this comment.
Should update the parameter docs to reflect the new default as well.
natelust
force-pushed
the
tickets/DM-17757
branch
from
c728307
to
6b7c3b6
Compare
Changing to None causes the module to be looked up from the control class, as numerical lookup proved to be unreliable.
natelust
force-pushed
the
tickets/DM-17757
branch
from
6b7c3b6
to
42ec858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default module to None
Changing to None causes the module to be looked up from the
control class, as numerical lookup proved to be unreliable.