Review for meas_base DM-2307: transformations for shape measurements #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,7 +130,8 @@ class ShapeResultKey : public afw::table::FunctorKey<ShapeResult> { | |||
| afw::table::Schema & schema, | |||
| std::string const & name, | |||
| std::string const & doc, | |||
| UncertaintyEnum uncertainty | |||
| UncertaintyEnum uncertainty, | |||
| afw::table::CoordinateType coordType=afw::table::CoordinateType::PIXEL | |||
There was a problem hiding this comment.
You use this like an enum class here but like a regular enum elsewhere. Unless I've caught you in the midst of changing it, one of these is wrong.
There was a problem hiding this comment.
In C++11, it's permitted to give scope to a regular enum. That is, afw::table::CoordinateType::PIXEL and afw::table::PIXEL are equivalent, and this does, in fact, work. I agree that this code is ugly & inconsistent, though.
It looks as though Swig is happy with enum class, so I think switching everything to that is a clear win.
jdswinbank
force-pushed
the
tickets/DM-2307
branch
2 times, most recently
from
eebdcd1
to
93c4a88
Compare
jdswinbank
force-pushed
the
tickets/DM-2307
branch
from
93c4a88
to
61374ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.