DM-31601: Add Tasks to force photometry from DataFrames #187
Conversation
yalsayyad
force-pushed
the
tickets/DM-31601
branch
from
33f228c
to
c32f75d
Compare
| def __init__(self, *, config=None): | ||
| super().__init__(config=config) | ||
| self.initInputs.remove("inputSchema") | ||
| self.inputs.remove("skyMap") |
There was a problem hiding this comment.
This is a sign that it'd be better to make a new ABC for both concrete implementations, instead of inheriting from the other concrete impl. I'd say that's a job for another ticket, but these are going to still show up in the config.connections for this task, and it can be a real pain to remove configs with breakage. Some copy-and-paste duplication would probably be better.
There was a problem hiding this comment.
Thanks, what I'm reading is that:
- First choice is an ABC
- Second choice is a non-inherited Connections class.
There was a problem hiding this comment.
...and I'm not super confident that (1) is even better than (2); I'm just guessing that is because you chose to inherit in the first place.
|
|
||
| def runQuantum(self, butlerQC, inputRefs, outputRefs): | ||
| inputs = butlerQC.get(inputRefs) | ||
| print([i.dataId for i in inputs['refCat']]) |
| def df2RefCat(self, dfList, exposureBBox, exposureWcs): | ||
| """Convert list of DataFrames to reference catalog | ||
|
|
||
| Concatenate list of DataFrames presumable from multiple patches and |
There was a problem hiding this comment.
"presumable" -> "presumably"?
| World coordinate system to convert sky coords in ref cat to | ||
| pixel coords with which to compare with exposureBBox | ||
|
|
||
|
|
| """Record the transformation of the reference catalog coord. | ||
| The coord recorded in the reference catalog is tranformed to the | ||
| measurement coordinate system and stored. | ||
| Parameters |
There was a problem hiding this comment.
| Parameters | |
| Parameters |
| catalog fields. Output fields are added to the output schema. | ||
| metadata : `lsst.daf.base.PropertySet` | ||
| Plugin metadata that will be attached to the output catalog. | ||
| Notes |
python/lsst/meas/base/plugins.py
Outdated
| Notes | ||
| ----- | ||
| This can be used as the slot centroid in forced measurement when only a | ||
| reference coord exits, allowing subsequent measurements to simply refer to |
There was a problem hiding this comment.
| reference coord exits, allowing subsequent measurements to simply refer to | |
| reference coord exists, allowing subsequent measurements to simply refer to |
Tasks seed forced photometry with ra/decl columns from DataFrames instead of SourceCatalogs.
yalsayyad
force-pushed
the
tickets/DM-31601
branch
from
c32f75d
to
c128351
Compare
Tasks seed forced photometry with ra/decl columns from
DataFrames instead of SourceCatalogs.