Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30927: Set calexp WCS to None for failed astrometric fit #188

Merged
merged 2 commits into from Sep 30, 2022
Merged

DM-30927: Set calexp WCS to None for failed astrometric fit #188

merged 2 commits into from Sep 30, 2022

Conversation

laurenam
Copy link
Contributor

No description provided.

@laurenam laurenam force-pushed the tickets/DM-30927 branch 3 times, most recently from a55c252 to 2cd6980 Compare September 23, 2021 19:18
@laurenam laurenam force-pushed the tickets/DM-30927 branch 2 times, most recently from 051dbab to 43d4de6 Compare April 12, 2022 02:18
@laurenam
Accommodate WCS to None on fail instead of raise
a89c3c1 
Forced photometry cannot be performed if there is no WCS associated with
the exposure (i.e. the astrometry task failed so it was set to None).  We
must therefore skip this step on WCS-less exposures.
@laurenam
Handful of Flake8 and doc updates
9f1672a
erykoff
erykoff approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen so many force pushes! 😭

@laurenam laurenam merged commit f5648a9 into main Sep 30, 2022
@laurenam laurenam deleted the tickets/DM-30927 branch September 30, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@laurenam @erykoff