DM-33854: Introduce heartbeat logs in ApplyApCorr #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-33854
branch
from
043d187
to
e1f8191
Compare
arunkannawadi
commented
Mar 2, 2022
| # Log a message if it has been a while since the last log. | ||
| if (currentTime := time.time()) > nextLogTime: | ||
| self.log.verbose("Aperture corrections applied to %d sources out of %d", | ||
| sourceIndex + 1, len(catalog)) |
There was a problem hiding this comment.
Thanks Tim! I just changed sourceIndex to sourceIndex + 1 to start the counting from 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some heartbeat logs in the aperture correction task, since it could take a couple of silent hours otherwise to finish the task.