DM-34770: Use PSF position explicitly to compute PSF size #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
May 12, 2022
src/LocalBackground.cc
Outdated
| @@ -67,7 +67,7 @@ void LocalBackgroundAlgorithm::measure(afw::table::SourceRecord& measRecord, | |||
| if (!psf) { | |||
| throw LSST_EXCEPT(MeasurementError, NO_PSF.doc, NO_PSF.number); | |||
| } | |||
| float const psfSigma = psf->computeShape().getDeterminantRadius(); | |||
| float const psfSigma = psf->computeShape(psf->getAveragePosition()).getDeterminantRadius(); | |||
There was a problem hiding this comment.
This should use the position at the center of the footprint. Though this will change the behavior, I believe the current behavior is incorrect.
erykoff
reviewed
May 12, 2022
src/LocalBackground.cc
Outdated
| @@ -67,7 +67,7 @@ void LocalBackgroundAlgorithm::measure(afw::table::SourceRecord& measRecord, | |||
| if (!psf) { | |||
| throw LSST_EXCEPT(MeasurementError, NO_PSF.doc, NO_PSF.number); | |||
| } | |||
| float const psfSigma = psf->computeShape().getDeterminantRadius(); | |||
| float const psfSigma = psf->computeShape(psf->getAveragePosition()).getDeterminantRadius(); | |||
There was a problem hiding this comment.
This should use the position at the center of the footprint. Though this will change the behavior, I believe the current behavior is incorrect.
There was a problem hiding this comment.
You're absolutely right.
arunkannawadi
force-pushed
the
tickets/DM-34770
branch
from
061390a
to
47be1d5
Compare
erykoff
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.