Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meas_base review for tickets/DM-3182 #21

Merged
merged 4 commits into from
Jul 28, 2015
Merged

meas_base review for tickets/DM-3182 #21

merged 4 commits into from
Jul 28, 2015

Commits on Jul 23, 2015

  1. Move BaseMeasurementTask into its own module

    Move BasePlugin, BasePluginConfig, BaseMeasurementTask and
    BaseMeasurementConfig to a new module baseMeasurement.py
    in order to allow BaseMeasurementTask access to ApplyApCorrTask.
    Without this refactoring it would be very difficult to avoid a
    circular import. This change is arguably an improvement because it
    moves higher-level code out of base.py and moves BaseMeasurementTask
    into a more obvious module (one that analogous to sfm.py and
    forcedMeasurement.py)
    r-owen committed Jul 23, 2015
    Configuration menu
    Copy the full SHA
    a7fdb0b View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2015

  1. Make BaseMeasurementTask and its subtasks apply aperture correction.

    BaseMeasurementTask and its subtasks now apply aperture correction
    as part of the run method. Most of the work is done in
    BaseMeaurementTask._applyApCorrIfWanted, a simple private wrapper
    around self.apCorrMap.run that only applies aperture corrections
    if wanted.
    r-owen committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    d31ee57 View commit details
    Browse the repository at this point in the history
  2. Make code pass pyflakes linter

    - Eliminate use of "from X import *"
    - Remove unused imports
    - Add a missing math import in one test
    - Add __all__ to some modules to avoid importing too many symbols
    - Import a few more files in __init__ (whose symbols were being
      pulled in due to lack of "__all__" in other modules).
    - Reorder a few imports to meet LSST standards
    - Stop assigning to variables that are not used; this showed
      up in a few unit tests and I left the computation in place,
      since performing the computation looked like it would
      probably be a useful test.
    r-owen committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    7131476 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6d951f View commit details
    Browse the repository at this point in the history