DM-35265: Reduce usage of MeasurementError #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer raises MeasurementError so there is no longer a log message to capture.
We no longer use lsst.log so there is no need to capture log output to files and read the files back again.
timj
changed the title
This makes the code a bit simpler and puts all the flag handling directly in measure(). It also removes a try/except.
timj
changed the title
timj
commented
Jun 17, 2022
TallJimbo
approved these changes
Jun 22, 2022
| @@ -381,8 +367,7 @@ std::pair<MaskedImageT, double> smoothAndBinImage(std::shared_ptr<afw::detection | |||
| try { | |||
| subImage.reset(new MaskedImageT(mimage, bbox, afw::image::LOCAL)); | |||
| } catch (pex::exceptions::LengthError &err) { | |||
| throw LSST_EXCEPT(MeasurementError, SdssCentroidAlgorithm::EDGE.doc, | |||
| SdssCentroidAlgorithm::EDGE.number); | |||
| return std::make_tuple(mimage, 0, SdssCentroidAlgorithm::EDGE.number); | |||
There was a problem hiding this comment.
If you want to remove this try/catch as well, I think the replacement is:
if (!mimage.getBBox(afw::image::LOCAL).contains(bbox)) {
return std::make_tuple(mimage, 0, SdssCentroidAlgorithm::EDGE.number);
}
subImage.reset(new MaskedImageT(mimage, bbox, afw::image::LOCAL));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.