DM-35725: Remove Gen2 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-35725
branch
3 times, most recently
from
b0f1f36
to
6714c44
Compare
laurenam
approved these changes
Aug 1, 2022
timj
force-pushed
the
tickets/DM-35725
branch
2 times, most recently
from
0c04945
to
8e285a3
Compare
This is seemingly only used for gen2
Seems like it's gen2 only.
Some users are passing in gen3 butler to the Task constructor even though it has always been a gen2 butler. We have to issue a warning such that we can remove the butler parameter later.
It's only now used by gen2 code and that is all going away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.