Review for DM-3400 (Eliminate circular aliases in slot centroid definition) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow plugins that depend on slots to create aliases directly to the slot algorithms themselves by resolving those aliases early. That makes it easier to catch cycles and dependencies that don't agree with the executionOrder values, and it ensures the aliases remain correct if the slots are later changed.
| else: | ||
| msConfig.slots.centroid = "base_SdssCentroid" | ||
|
|
||
| msConfig.slots.centroid = "base_SdssCentroid" |
There was a problem hiding this comment.
You've eliminated the only use of the runCentroider argument. Drop it entirely?
This also removes an invalid test, that tried to verify that we could run the default suite of algorithms without running a centroider: we can't, because most of those algorithms do depend on running a centroider.
TallJimbo
force-pushed
the
tickets/DM-3400
branch
from
46e871c
to
2c1de74
Compare
This requirement was already document and should have been guaranteed by higher-level code, but until recently was not; this ensures that mistake can't happen again.
The catalog produced by the test utility code contains truth value fields, and by default the slots are set to those values. We now remove those default slotss when using the task config to set the slots, so the config values are fully obeyed.
TallJimbo
force-pushed
the
tickets/DM-3400
branch
from
2c1de74
to
a06b53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.