DM-32396: Initial version of the near edge fallback on SdssCentroid. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
changed the title
TallJimbo
reviewed
Dec 3, 2022
| if (errorFlag != NEAR_EDGE.number) { | ||
| _flagHandler.setValue(measRecord, SdssCentroidAlgorithm::FAILURE.number, true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think it's more conservative to keep considering this a FAILURE until we have evidence from processing that the fallback is not too bad.
enourbakhsh
force-pushed
the
tickets/DM-32396
branch
from
930f269
to
4685f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.