-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meas_base DM-1954: HeavyFootprints in forced coadd photometry #23
Commits on Aug 13, 2015
-
forcedPhotImage: allow schema to be specified in constructor
When these Tasks are run in their own stand-alone scripts, the schema is loaded through the butler. However, when they are run as part of a common operation, the Tasks are instantiated before the schemas are written out, and so they need to be given the schemas at construction time. This change makes both possible: the schema is used if provided, otherwise loaded from the butler. Note: this is essentially a cherry-pick from HSC-1063 except that we still refer to Coadd_src_schema instead of Coadd_ref_schema. This will likely change once we have the multiband processing working on the LSST stack.
Configuration menu - View commit details
-
Copy full SHA for 346bea9 - Browse repository at this point
Copy the full SHA 346bea9View commit details -
CoaddSrcReferencesTask: make the dataset suffix a class variable
While we may want to load from deepCoadd_src, under the multiband processing scheme it's deepCoadd_ref, so that suffix needs to be customisable. Have NOT gone to deepCoadd_ref exclusively yet, so the old forced photometry should still work.
Configuration menu - View commit details
-
Copy full SHA for 4b14967 - Browse repository at this point
Copy the full SHA 4b14967View commit details -
Use IDs from reference catalog in coadd forced photometry
Now that we have consistent source IDs across all coadd measurement catalogs (because we're merging at the Footprint/Peak level before deblending), those catalogs can all have consistent IDs, instead of generating their own. That means we want to use the reference catalog ID as the source ID in forced photometry. This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@d85a382
Configuration menu - View commit details
-
Copy full SHA for aaa5ba4 - Browse repository at this point
Copy the full SHA aaa5ba4View commit details -
ForcedPhot tasks are now responsible for attaching Footrints to sources
Forced photometry previously relied on the MeasureSources class to transform reference Footprints and attach them to sources, but we've moved that responsibility here so we can override it at the Python level in the future. This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@0f29c18
Configuration menu - View commit details
-
Copy full SHA for 0e1d0eb - Browse repository at this point
Copy the full SHA 0e1d0ebView commit details -
Use (Heavy)Footprints from post-merge measurements in forced photometry
This allows us to use deblend results from the single-band measurement phase to replace neighbors with noise in forced photometry. This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@2218b2e
Configuration menu - View commit details
-
Copy full SHA for bff4677 - Browse repository at this point
Copy the full SHA bff4677View commit details -
MultiBandReferences doesn't require coaddName=chisq
MultiBandReferences can't delegate its config validation directly to CoaddSrcReferences, because that includes a check for chi-squared coadd that we don't want. This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@14efa55
Configuration menu - View commit details
-
Copy full SHA for a23d0b5 - Browse repository at this point
Copy the full SHA a23d0b5View commit details -
Switch default forced phot references to multi-band
This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@814036b
Configuration menu - View commit details
-
Copy full SHA for 5d5c6f2 - Browse repository at this point
Copy the full SHA 5d5c6f2View commit details -
Improve log messages in forced photometry
Printing out the number of sources isn't as useful as printing the data ID, especially when we already have other log messages that print the same number This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@da5a18d
Configuration menu - View commit details
-
Copy full SHA for 07429f0 - Browse repository at this point
Copy the full SHA 07429f0View commit details -
Don't attempt to remove patch overlaps in coadd forced photometry
Now that we're trying to use deblended HeavyFootprints here, we can't afford to have parent footprints rejected as being in the overlap region if their children might not be rejected, because the ReplaceWithNoiseTask requires all sources to have a parent. In order to change this back, we'd need more intelligent handling of the overlaps. But once this is loaded into the database, we should be able to join with the main measurement catalog and just use the "primary" flags there to handle overlaps. This is essentially a cherry-pick from HSC-1062's commit: HyperSuprime-Cam/pipe_tasks@681422d
Configuration menu - View commit details
-
Copy full SHA for 9b6b652 - Browse repository at this point
Copy the full SHA 9b6b652View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9bdc6a - Browse repository at this point
Copy the full SHA e9bdc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ecb41b - Browse repository at this point
Copy the full SHA 5ecb41bView commit details -
Put reference object IDs in regular "id" field in CCD forced photometry.
Instead of having a separate ID for each forced source, we'll just have the foreign key to the coadd-based references. We'll do the same with the deblender fields (since there isn't any deblending in CCD forced photometry anyway). This is essentially a cherry-pick from HSC-1218's commit: HyperSuprime-Cam/pipe_tasks@9e72537
Configuration menu - View commit details
-
Copy full SHA for c091ea9 - Browse repository at this point
Copy the full SHA c091ea9View commit details -
Filter reference sources in forced photometry by deblend family
The ReplaceWithNoise procedure in measurement requires all child sources to have their parents present, so we can't do any kind of filtering that could cut a parent but not one or more of its children. This is essentially a cherry-pick of the changes to reference.py from HSC-1218's commit (i.e. the changes to forcedPhotImage.py were not made as they are not appropriate): HyperSuprime-Cam/pipe_tasks@c442bc9
Configuration menu - View commit details
-
Copy full SHA for 8832527 - Browse repository at this point
Copy the full SHA 8832527View commit details -
Move reference filtering from forcedPhotImage to forcedPhotCcd.
This is essentially a cherry-pick of the changes to forcedPhotCcd.py from HSC-1256's commit (i.e. the changes to forcedPhotImage.py were not made as they are not appropriate): HyperSuprime-Cam/pipe_tasks@d369520
Configuration menu - View commit details
-
Copy full SHA for de7de8e - Browse repository at this point
Copy the full SHA de7de8eView commit details -
Fix trivial bugs in forced photometry from HSC-1256
A broken, pre-review version of HSC-1256 was accidentally merged to master. This is essentially a cherry-pick of the changes to forcedPhotCcd.py from HSC's stand-alone commit (i.e. the changes to forcedPhotImage.py were not made as they are not appropriate): HyperSuprime-Cam/pipe_tasks@d6d652b
Configuration menu - View commit details
-
Copy full SHA for e44735b - Browse repository at this point
Copy the full SHA e44735bView commit details -
Raise error if reference list contains parent-less children
Check that the reference catalog does not contain any children for which any member of their parent chain is not within the list. This can occur at boundaries when the parent is outside and one of the children is within. Currently, the parent chain is always only one deep, but just in case, this code checks for any case where when the parent chain to a child's topmost parent is broken and raises an exception if it occurs.
Configuration menu - View commit details
-
Copy full SHA for 6c11b31 - Browse repository at this point
Copy the full SHA 6c11b31View commit details -
Remove footprint attachment from generateSources()
Footprints are now attached to the sources using the class's implementation of attachFootprints().
Configuration menu - View commit details
-
Copy full SHA for b97dcc7 - Browse repository at this point
Copy the full SHA b97dcc7View commit details -
Move call to generateSources() to ProcessImageForcedTask
Moving the source generation from ForcedMeasurementTask in forcedMeasurement.py to ProcessImageForcedTask in forcedPhotImage.py is required so that we can pass the sources to attachFootprints() before measurement of forced photometry.
Configuration menu - View commit details
-
Copy full SHA for c9d69ec - Browse repository at this point
Copy the full SHA c9d69ecView commit details -
Add ${PRODUCT_DIR}/bin to PATH in meas_base.table
Needed to access forcedPhotCcd.py and forcedPhotCoadd.py command line tasks.
Configuration menu - View commit details
-
Copy full SHA for edbb044 - Browse repository at this point
Copy the full SHA edbb044View commit details -
Configuration menu - View commit details
-
Copy full SHA for def7c24 - Browse repository at this point
Copy the full SHA def7c24View commit details -
Do not convert reference catalog to a list
In doing so we would lose the attributes of the SourceCatalog (e.g. getChildren()) which are required by the measurement.
Configuration menu - View commit details
-
Copy full SHA for 622f3e7 - Browse repository at this point
Copy the full SHA 622f3e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7b35a - Browse repository at this point
Copy the full SHA 2d7b35aView commit details -
Move default Footprint attachment to ForcedMeasurementTask
This is required so that Footprints can be attached to the generated sources prior to forced measurement. ForcedPhotImageTask inherits this default method (which downgrades HeavyFootprints into regular Footprints). Subclasses for ForcedPhotImageTask must implement their own version of this method to define how those Footprints should be generated.
Configuration menu - View commit details
-
Copy full SHA for 086321b - Browse repository at this point
Copy the full SHA 086321bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4224f62 - Browse repository at this point
Copy the full SHA 4224f62View commit details -
Update exposure name for forced coadd photometry
We need to do forced measurement using the exposure that has had it's background fields updated in the multi-band measurement stage. See lsst/pipe_tasks@7901922
Configuration menu - View commit details
-
Copy full SHA for aeac5aa - Browse repository at this point
Copy the full SHA aeac5aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd6fdb3 - Browse repository at this point
Copy the full SHA fd6fdb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a354455 - Browse repository at this point
Copy the full SHA a354455View commit details