Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37058: Disable unnecessary measurements in CCD forced photometry #244

Merged
merged 6 commits into from
Jun 7, 2023
Merged

DM-37058: Disable unnecessary measurements in CCD forced photometry #244

merged 6 commits into from
Jun 7, 2023

Commits on Jun 6, 2023

  1. Remove deprecated butler kwargs

    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ebdcb26 View commit details
    Browse the repository at this point in the history

  2. Rename kwds->kwargs to follow our convention

    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9334d8e View commit details
    Browse the repository at this point in the history

  3. Minimize measurement plugins in ForcedPhotCcdConfig 

    We only care about single visit forced photometry for variable sources, thus
we only need PSF flux, flags, and the centroid it was forced from.
    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ef1e01d View commit details
    Browse the repository at this point in the history

  4. Add trivial tests of ForcedPhotCcd tasks 

    These tests confirm that the tasks can be initialized and produce
non-NaN output, but nothing more than that.
    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    dd1ae13 View commit details
    Browse the repository at this point in the history

  5. Set doReplaceWithNoise=False for ForcedPhotCcdTask 

    This makes it consistent with the newer ForcedPhotCcdFromDataFrameTask.
    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e157104 View commit details
    Browse the repository at this point in the history

  6. Need localX measurements for postprocess.py

    @parejkoj
    parejkoj committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    a296f6f View commit details
    Browse the repository at this point in the history