DM-39227: rework (with deprecation) ForcedPhotCcd external-calibration connections. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
bb6a2a8
to
7663de0
Compare
laurenam
approved these changes
Jul 12, 2023
| @@ -748,7 +779,8 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
| skyCorr=skyCorr, | |||
| externalSkyWcsCatalog=externalSkyWcsCatalog, | |||
| externalPhotoCalibCatalog=externalPhotoCalibCatalog, | |||
| finalizedPsfApCorrCatalog=finalizedPsfApCorrCatalog | |||
| finalizedPsfApCorrCatalog=finalizedPsfApCorrCatalog, | |||
| visitSummary=inputs.pop("visitSummary"), | |||
There was a problem hiding this comment.
Barely worth mentioning, but you used single quotes for this above.
The deprecation message unfortunately didn't include the "remove after" version, but it was added back in v20, so it's plenty safe to remove now.
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
7663de0
to
dcf1495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.