DM-39796: Update task config defaults to LSST values #253
Conversation
| @@ -37,7 +37,7 @@ class CatalogCalculationClassificationConfig(CatalogCalculationPluginConfig): | |||
| """Configuration for catalog classification plugin. | |||
| """ | |||
|
|
|||
| fluxRatio = lsst.pex.config.Field(dtype=float, default=.925, optional=True, | |||
| fluxRatio = lsst.pex.config.Field(dtype=float, default=.95, optional=True, | |||
There was a problem hiding this comment.
I'm not suggesting this is wrong, but just wanted to note that this prioritizes the value appropriate for a PSF vs. Gaussian flux ratio (as is used in SFM). For cModel vs. PSF, as an example, the canonical value we use is 0.985 (so each obs package needs to have a cmodel.py config override file:
https://github.com/lsst/obs_lsst/blob/main/config/cmodel.py#L27
https://github.com/lsst/obs_subaru/blob/main/config/cmodel.py#L7
https://github.com/lsst/obs_decam/blob/main/config/cmodel.py#L7
etc...
There was a problem hiding this comment.
So it looks like we have overrides for the various cameras already?
The only places where those cmodel overrides are used are characterizeImage (which shouldn't be doing cmodel measurements anyway, and will be replaced with CalibrateImage, where no cmodel measurements are done), forcedPhotcoadd, and measureCoaddSources. There's nothing instrument-specific about the overrides you mention above, so we should absolutely move those into the task defaults for those two respective tasks and get rid of the above override files. I'm not going to add more to this ticket, but we already know that there's more cleanup like this ticket to be done, and this is a good example of it.
parejkoj
force-pushed
the
tickets/DM-39796
branch
from
109520a
to
bc1ab6f
Compare
0.95 is the default for calibrate in LSST and HSC.
parejkoj
force-pushed
the
tickets/DM-39796
branch
from
bc1ab6f
to
1dc6444
Compare
No description provided.