Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41345: Make TestDataset catalog look more like Calibrate output #257

Merged
merged 2 commits into from Nov 2, 2023

Conversation

parejkoj
Copy link
Contributor

No description provided.

Everywhere that uses TestDataset probably wants the error keys, so do
this at the deepest level, instead of individual tests.
TestDataset is supposed to represent the output of single frame
measurement, which is going to have coordinates if it has a WCS.
@parejkoj parejkoj changed the title DM-41345: Add the coord error key in TestDataset DM-41345: Make TestDataset catalog look more like Calibrate output Oct 27, 2023
Copy link
Contributor

@cmsaunders cmsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I don't any of the other tests use the coordinates, so I guess moving updateSourceCoords into the lower-level class doesn't change anything.

@parejkoj parejkoj merged commit e56fc97 into main Nov 2, 2023
2 checks passed
@parejkoj parejkoj deleted the tickets/DM-41345 branch November 2, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants