DM-37386: Add a CenterAll flag during detect and measure #260
Conversation
There was a problem hiding this comment.
Ok, it took me a little while but I think I understand how this works now. I think that the use of _bits and _bitsAll is confusing, since _bitsAll doesn't really mean all of the bits in the footprint had a given masked bit set, just the center 3x3 grid, and when paired with _bits it's more confusing.
I understand what you were trying to convey, since _bits is the union of all of the bits in the spanset and _bitsAll is the intersection of all of the bits in the spanset, so I would recommend renaming them accordingly, ie. _unionBits and _intersectionBits, or _anyBit and _allBits.
| _centerKeys["BAD"] = schema.addField<afw::table::Flag>(name + "_flag_badCenter", | ||
| "Bad pixel in the 3x3 region around the centroid"); |
There was a problem hiding this comment.
I'm not sure why this is formatted differently than all of the other schema fields.
There was a problem hiding this comment.
Formatting is entirely determined by clang-format: in this case, I think it's because the docstring is shorter.
Rename bits in file-local FootprintBits to distinguish the two kinds.
parejkoj
force-pushed
the
tickets/DM-37386
branch
from
d920f0b
to
219b5ca
Compare
No description provided.