Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42313: PixelFlags offimage check should flag non-finite positions #261

Merged
merged 5 commits into from
Jan 3, 2024

Commits on Jan 2, 2024

  1. Clarify edge flag

    The code had set flag_edge if the source was off the chip, but the
    docstring did not specify that.
    parejkoj committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9eb8881 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c788f4f View commit details
    Browse the repository at this point in the history
  3. Cast image bbox to allow checking of non-finite centroids

    There is no Box2I.contains(Point2D), so we have to cast the box instead
    of the centroid, if we want it to work for non-finite values.
    parejkoj committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    ab9caf6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Move centroid finitness check and rework exception

    Catching NaN centroids early means that the offimage flag is not set
    for them, but it should be.
    Reformat exception message to be more useful (although the measurement
    task squashes all these to debug level logs, so noone ever sees them
    anyway).
    Add tests of non-finite centroids and sources right on the image boundary.
    parejkoj committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4ae9f99 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary tearDown

    parejkoj committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f4c3f67 View commit details
    Browse the repository at this point in the history