DM-41700: Deprecate Naive Centroid #268
Conversation
parejkoj
force-pushed
the
tickets/DM-41700
branch
from
093a914
to
ad92421
Compare
| class NaiveCentroidControl { | ||
| class [[deprecated( | ||
| "This algorithm and its control class are deprecated and will be removed after " | ||
| "v27.")]] NaiveCentroidControl { |
There was a problem hiding this comment.
It'd be best to suppress these warnings in the pybind11 module so we don't see them when compiling that also-deprecated code. The preprocessor directives to do that can be found in the dev guide just above your new paragraph.
There was a problem hiding this comment.
Thanks. I had to put the pragma around the entire pybind11 block in the namespace, but that did take care of the compiler warnings.
| @@ -23,6 +23,6 @@ | |||
| from _sillyCentroid import SillyCentroidAlgorithm, SillyCentroidControl, SillyTransform | |||
|
|
|||
| # Do not register SillyCentroid in plugins.py, as it's not part of meas_base | |||
| wrapSimpleAlgorithm(SillyCentroidAlgorithm, Control=SillyCentroidControl, | |||
| wrapSimpleAlgorithm(SillyCentroidAlgorithm, Control=SillyCentroidControl, name="testLib_SillyCentroid", | |||
There was a problem hiding this comment.
I think this algorithm is just on the border of being simple enough that it might have saved time to reimplement it in pure Python. But now that you've done it this way that's probably not worth it.
There was a problem hiding this comment.
Yeah, it took me a bit to sort out the various "testLib" references (and lack thereof), but this works fine. Having someone implement SillyCentroid (which is basically identical to NaiveCentroid) in python might be a useful training exercise for a newer developer, but is otherwise not worth it.
parejkoj
force-pushed
the
tickets/DM-41700
branch
from
ad92421
to
33bb366
Compare
* Add new deprecation system for registered C++ plugins. * Use pure-test-based SillyCentroid to replace NaiveCentroid in tests. * Mark code to remove on DM-41701, once the deprecation period has passed.
parejkoj
force-pushed
the
tickets/DM-41700
branch
from
33bb366
to
5e4533d
Compare
No description provided.