DM-43969: Call MeasurementError correctly in sizeExtendedness plugin #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-43969
branch
3 times, most recently
from
1ceea79
to
ac2ca3a
Compare
in sizeExtendedness plugin.
arunkannawadi
force-pushed
the
tickets/DM-43969
branch
from
ac2ca3a
to
c4a3a53
Compare
parejkoj
approved these changes
Apr 19, 2024
tests/test_MomentsClassifier.py
Outdated
| @@ -56,6 +56,20 @@ def testSingleFramePlugin(self): | |||
| for ii in range(self.n_stars, self.n_stars + self.n_gals): | |||
| self.assertGreater(catalog[ii].get("base_ClassificationSizeExtendedness_value"), 0.02) | |||
|
|
|||
| def testFailure(self): | |||
| """Test that MeasurementError is raised properly.""" | |||
There was a problem hiding this comment.
Please say here why MeasurementError should be raised in this test?
| plugin = task.plugins["base_ClassificationSizeExtendedness"] | ||
| plugin_order = plugin.getExecutionOrder() | ||
| task.run(catalog, exposure, endOrder=plugin_order) | ||
| catalog["slot_Shape_flag"] = 1 |
There was a problem hiding this comment.
I assume this is what causes the raise?
tests/test_MomentsClassifier.py
Outdated
| catalog["slot_Shape_flag"] = 1 | ||
| for record in catalog: | ||
| with self.subTest(id=record["id"]): | ||
| with self.assertRaises(measBase.MeasurementError): |
There was a problem hiding this comment.
Please use assertRaisesRegex to confirm that the error you expected is what is being raised. I think just "Shape flag is set." is enough.
arunkannawadi
force-pushed
the
tickets/DM-43969
branch
from
c4a3a53
to
ac5733b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.