Review for DM-3257 (Port flux.scaled from HSC) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-3257
branch
from
50e0d3c
to
1878e11
Compare
Moving this out of the anonymous namespace so that we can refer to it from other algorithms which do not directly use ApertureFluxAlgorithm.
jdswinbank
force-pushed
the
tickets/DM-3257
branch
from
1878e11
to
9a4f1c2
Compare
This algorithm measures the flux in a circular aperture of diameter equal to some (configurable) multiple of the PSF FWHM. This is a port of work carried out on Hyper Suprime-Cam under ticket HSC-1295 (https://hsc-jira.astro.princeton.edu/jira/browse/HSC-1295),
jdswinbank
force-pushed
the
tickets/DM-3257
branch
from
1d24810
to
b035625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.