DM-5877: Use Afterburners to clean up aperture correction logic #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| class ABClassificationConfig(AfterburnerPluginConfig): | ||
|
|
There was a problem hiding this comment.
Remove the blank line since it doesn't add anything and adds potential for the parts being separated.
natelust
force-pushed
the
tickets/DM-5877
branch
4 times, most recently
from
c1e5048
to
0577a7c
Compare
| copyColumns = lsst.pex.config.DictField( | ||
| keytype=str, itemtype=str, doc="Mapping of reference columns to source columns", | ||
| default={"id": "objectId", "parent": "parentObjectId", "deblend_nChild": "deblend_nChild"} | ||
| ) | ||
|
|
||
| def setDefaults(self): | ||
| # Make afterburners a NoOp by default as not modelFlux is setup by default in | ||
| # ForcedMeasurementTask |
There was a problem hiding this comment.
"not" - > "no", "NoOp" -> "no-op" (don't want CamelCase to imply it's a class).
The afterburner task contained no reference to the plugin map for afterburner plugins. This make it impossible to reference the plugins though the class itself. Added map to facilitate this functionality
The classification plugin is now a afterburner plugin instead of a measurement plugin. Created a new classificatioin module to hold all future classification plugins. Removed classification run order, as it is now the same run ordering as afterburners
Remove all the logic of aperture corrections from the measurement plugins. In the future MeasureApCorr and ApplyApCorr tasks should be called directly when that functionality is required.
Since aperture corrections have been moved out of the base measurement task, application of aperture corrections and the afterburner task must be added to tasks which need these functionalities. Since the forced measurement task has no default model flux, afterburners are set to a NoOp by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.