New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-6999: Logging framework migration #47
Conversation
83236e7
to
2729579
Compare
It's slightly outside the scope of this pull request, but there are a few lines in these files that could really use to be cleaned up:
in noiseReplacer.py:
|
The code changes all look fine. I don't have the new lsst.log so the changed tests all fail for me, but assuming that they do all pass with the new framework this branch can be merged. |
2729579
to
2faed74
Compare
@@ -34,6 +34,7 @@ | |||
import numpy as np | |||
|
|||
import lsst.pex.logging as pexLogging | |||
from lsst.log import Log | |||
import lsst.pex.exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to remove this, and the code below that uses it? (I didn't see any other instances, but suggest a global search to be sure).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log
is used in line 53 below, also added by this commit.
However, I actually cannot find any logs in afw
that logs to afwDetection.Measure
. It's likely for some old codes that have been replaced? I will delete these debugging placeholders.
Thanks for the pytest work, testFlagHandler.py and noiseReplacer.py have been cleaned up! :-) |
a11d8f9
to
886976b
Compare
- Replace pex.logging logdebug using lsst.log.Log DEBUG level - Remove some unused pex.logging dependency
Currently there is not a logger named "afwDetection.Measure" in afw.
886976b
to
1f1f621
Compare
No description provided.