Rename afterburner to catalogCalculation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "plugin. Value {} : Minimum {}".format(PluginClass, | ||
| PluginClass.getExecutionOrder(), | ||
| BasePlugin.DEFAULT_CATALOGCALCULATION) | ||
| ) |
There was a problem hiding this comment.
Is there a reason that the closing parenthesis is not on the last line of the code? This doesn't seem to be specified in the style guide so I'm just wondering if there is a preferred nomenclature for the LSST pipeline.
There was a problem hiding this comment.
because one more character takes the line past its maximum 110 character limit, so it flows to the next line indented to the same level as the opening parentheses. You are right about there not being anything special about parentheses being on their own lines.
natelust
force-pushed
the
tickets/DM-6919
branch
from
97ddf67
to
714a570
Compare
To improve readability and limit ambiguity in function, afterburners is renamed to catalogCalculation
natelust
force-pushed
the
tickets/DM-6919
branch
from
714a570
to
ef693ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve readability and limit ambiguity in function, afterburners
is renamed to catalogCalculation