DM-1331 #5
Merged
DM-1331 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjuric
force-pushed
the
u/jbosch/DM-1331
branch
from
9aa4b14
to
bcc2944
Compare
The first several lines of the previous version could be accomplished by simply inheriting from meas.base.tests.AlgorithmTestCase, which additionally puts that code in setUp(), allowing it to be reused for other test functions. Also fixed non-conformant variable names.
mjuric
force-pushed
the
u/jbosch/DM-1331
branch
from
bcc2944
to
6cae377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch some on-the-edge exceptions and rethrow as MeasurementError, to set flags on sources instead of sending a warning to the log.