DM-7262: Port to Python 3 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| afwImage.ImageF(kimg.getDimensions(), 0.0)) | ||
| kimg *= 100.0 | ||
| mimg = afwImage.MaskedImageF(kimg.convertFloat(), | ||
| afwImage.MaskU(kimg.getDimensions(), 0x0), |
There was a problem hiding this comment.
I'm intrigued by the 0x0 here. Doesn't seem to be any different to a straight 0.
There was a problem hiding this comment.
Nicely said. I think it was intended to emphasize that this is a mask, whose values are usually set as hex values.
r-owen
force-pushed
the
tickets/DM-7262
branch
4 times, most recently
from
58650b4
to
2ea7495
Compare
Standardize order and grouping of imports Import numpy as np Remove unused imports Use lsst.utils.getPackageDir instead of eups.packageDir
Don't set unused variables Wrap long lines Use is/is not None instead of ==/!= Use "foo not in bar" instead of "not foo in bar"
Fixed undefined variables in an unused functor in growthcurve.py
and the associated comment
Renamed multiple references to ProcessImageForcedTask/Config to ForcedPhotImageTask/Config. The new name is more consistent with the classes that inherit from these, and there were multiple instances in the existing code base that assumed the new name (mostly in comments, but also in code). Note that these classes are only used in meas_base, because the task is an abstract base class, so this change will not affect any other module.
Standarize the way long strings are distributed across multiple lines: - no + to separate - a space separator goes on the end, not the beginning - indent continuation strings appropriately
For str % formatting of a single value, always enclose that value in ( ,) to make it a tuple, for type safety, e.g. `str % (foo,)` not `str % foo`
lsst.utils is used in at least one place and so is an explicit dependency
r-owen
force-pushed
the
tickets/DM-7262
branch
from
2ea7495
to
01635fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.