refactor undeblended measurement into BaseMeasurementTask #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djreiss
commented
Dec 16, 2016
| @@ -131,6 +147,8 @@ class BaseMeasurementConfig(lsst.pex.config.Config): | |||
| dtype=NoiseReplacerConfig, | |||
| doc="configuration that sets how to replace neighboring sources with noise" | |||
| ) | |||
| undeblendedPrefix = lsst.pex.config.Field(dtype=str, default="undeblended_", | |||
| doc="Prefix to give undeblended plugins") | |||
There was a problem hiding this comment.
Would be easier to read if formatted the same as previous Field declarations - i.e. newline after "("
| default=[], | ||
| doc="Plugins to run on undeblended image" | ||
| ) | ||
| undeblendedPrefix = lsst.pex.config.Field(dtype=str, default="undeblended_", |
There was a problem hiding this comment.
Also here -- newline after "("
This makes it available in the ForcedMeasurementTask as well as SingleFrameMeasurementTask. Unfortunately, the actual measurement iteration cannot live in BaseMeasurementTask because the forced measurement requires iterating through two catalogs in sync, while the single frame measurement only has one.
PaulPrice
force-pushed
the
tickets/DM-7889
branch
from
7d67323
to
656ff74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it available in the ForcedMeasurementTask as well as
SingleFrameMeasurementTask. Unfortunately, the actual measurement
iteration cannot live in BaseMeasurementTask because the forced
measurement requires iterating through two catalogs in sync, while
the single frame measurement only has one.