U/pgee/dm 1013 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -137,23 +137,39 @@ def __init__(self, config, name, schema, metadata): | |||
| SingleFramePlugin.__init__(self, config, name, schema, metadata) | |||
| self.keyProbability = schema.addField(name + "_value", type="D", | |||
| doc="Set to 1 for extended sources, 0 for point sources.") | |||
| self.keyFlag = schema.addField(name + "_flag", type="Flag", | |||
| doc="Set to 1 for any fatal failure.") | |||
There was a problem hiding this comment.
The indentation here is a bit weird -- it's not a fatal flaw, but it would be nicer if the "d" of "doc" appeared directly beneath the "n" of "name". In fact, the text is short enough that everything would fit on a single line, which would be better still.
There was a problem hiding this comment.
This and all the following minor formatting problems were fixed. I won't add a comment for each one.
…ropriately
Failure modes are: ModelFluxFlag or PsfFluxFlag are True when the measure is called
ModelFlux or PsfFlux are NAN when the measure is called
ModelFluxErr is NAN when the modelFluxFactor is non-zero, else Err is ignored
PsfFluxErr is NAN when the psfFluxFactor is non-zero, else Err is ignored
Review issues addressed
mjuric
force-pushed
the
u/pgee/DM-1013
branch
from
903fa4a
to
cfa21d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for review.