Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 1218 #8

Merged
merged 5 commits into from
Jan 27, 2015
Merged

Tickets/dm 1218 #8

merged 5 commits into from
Jan 27, 2015

Commits on Jan 22, 2015

  1. Give BasePlugin a non-trivial constructor.

    This guarantees that BasePlugin instances have the attributes set there
    without having to assume anything about their subclasses.
    TallJimbo committed Jan 22, 2015
    Configuration menu
    Copy the full SHA
    2d4da40 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2015

  1. Move plugin initialization to BaseMeasurementTask

    This removes some code duplication at the expense of a bit of opaque
    argument-forwarding.  It'll become more important shortly, as the
    now-shared code is about to grow.
    TallJimbo committed Jan 27, 2015
    Configuration menu
    Copy the full SHA
    33d9d6a View commit details
    Browse the repository at this point in the history
  2. Reorganize ApertureFlux outputs for consistency with slots.

    This changes aperture flux outputs to look more like an array-of-structs
    rather than a struct of array, e.g. "base_CircularApertureFlux_[0,1,2]_flux"
    instead of "base_CircularApertureFlux_flux_[0,1,2]".  This makes it
    its field suffixes compatible with the slot mechanism.
    TallJimbo committed Jan 27, 2015
    Configuration menu
    Copy the full SHA
    8000b83 View commit details
    Browse the repository at this point in the history
  3. Remove NaiveFlux and SincFlux, replacing them with CircularApertureFlux

    Now that it can participate in slots, CircularApertureFlux can do everything
    NaiveFlux and SincFlux once did, so there's no need for all that code duplication
    and boilerplate.
    TallJimbo committed Jan 27, 2015
    Configuration menu
    Copy the full SHA
    788e7bc View commit details
    Browse the repository at this point in the history
  4. Move ApertureFlux methods to protected to fix Python signature errors

    A "using" declaration to un-shadow the multiple overloads of measure() doesn't
    appear to work with Swig, so we move those methods to protected to make
    Swig continue to call throught the base class interface, which works fine.
    TallJimbo committed Jan 27, 2015
    Configuration menu
    Copy the full SHA
    9dd3f51 View commit details
    Browse the repository at this point in the history