DM-10237: fix errors in blendedness calculation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
reviewed
Apr 20, 2017
src/Blendedness.cc
Outdated
| @@ -284,6 +279,22 @@ BlendednessAlgorithm::BlendednessAlgorithm(Control const & ctrl, std::string co | |||
| } | |||
| } | |||
|
|
|||
| float BlendednessAlgorithm::computeAbsExpectation(float data, float variance) { | |||
| float normalization = 0.5f*boost::math::erfc(-data/std::sqrt(2.0f*variance)); | |||
There was a problem hiding this comment.
std::erfc available with C++11?
There was a problem hiding this comment.
It hadn't occurred to me to check, but it looks like it is. I'll update all the code using the boost version in this file.
yalsayyad
reviewed
Apr 20, 2017
tests/testBlendedness.py
Outdated
| @@ -24,6 +24,8 @@ | |||
| from contextlib import contextmanager | |||
| import unittest | |||
|
|
|||
| import numpy as np | |||
There was a problem hiding this comment.
Leftover import from debugging?
There was a problem hiding this comment.
From an older form of the test, yes.
TallJimbo
force-pushed
the
tickets/DM-10237
branch
from
8b7050e
to
3e3366c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses three problems in the blendedness calculation:
I've also added some new unit tests.