DM-11514: Fix pytest execution #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Aug 8, 2017
timj
commented
- Ignore non-test python files.
- Correct name for setup_module.
- Also rename test files.
kfindeisen
approved these changes
Aug 8, 2017
tests/SConscript
Outdated
|
|
||
| scripts.BasicSConscript.pybind11(pybind11_test_modules) | ||
| scripts.BasicSConscript.tests(noBuildList=[name + '.cc' for name in pybind11_test_modules]) | ||
| scripts.BasicSConscript.tests(noBuildList=[name + '.cc' for name in pybind11_test_modules], | ||
| ignoreList=ignoreList) |
There was a problem hiding this comment.
Perhaps make the code more symmetric, so it's easier to read?
There was a problem hiding this comment.
you mean move the noBuildList list building outside? Ok.
|
I'll annotate jira. The problem is the work on the ticket has not yet finished (sconsUtils) but the work like this can be merged early. |
timj
force-pushed
the
tickets/DM-11514-meas_base
branch
from
6969949
to
1d4a97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.