Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getTempFilePath to use unique log names #92

Merged
merged 2 commits into from Aug 21, 2017

Conversation

timj
Copy link
Member

@timj timj commented Aug 19, 2017

No description provided.

@timj timj requested a review from jdswinbank August 19, 2017 04:52
Copy link
Contributor

@jdswinbank jdswinbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes on this PR look fine. I'm a bit confused as to how they're supposed to relate to DM-11514 — the branch name implies that's where they're coming from, but that ticket is already marked as "reviewed".

@timj
Copy link
Member Author

timj commented Aug 21, 2017

This was a minor change directly related to DM-11514 that I was going to sort out so I left the work on the ticket. It wouldn't be needed if we weren't trying to get DM-11514 merged. The reason DM-11514 was "Reviewed" was that it was reviewed before people asked for xdist support to be added. That multi-process change led to all these additional problems. Thanks for the review.

@timj timj merged commit 927402a into master Aug 21, 2017
@ktlim ktlim deleted the tickets/DM-11514-meas_base-xdist branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants