Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11620: Numerical problem with Gaussian test in meas_base with pytest #94

Merged
merged 10 commits into from
Aug 31, 2017
Merged

DM-11620: Numerical problem with Gaussian test in meas_base with pytest #94

merged 10 commits into from
Aug 31, 2017

Commits on Aug 31, 2017

  1. Do not alter global state when perturbing WCS.

    @jdswinbank @laurenam
    jdswinbank authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    d0dac9f View commit details
    Browse the repository at this point in the history

  2. Make Gaussian flux tests deterministic. 

    Rather than relying on the state of the RNG, we always use a local random
state and seed it explicitly. This should make us robust against test failures
due to "polluted" randomness.
    @jdswinbank @laurenam
    jdswinbank authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    a44d823 View commit details
    Browse the repository at this point in the history

  3. Make PSF flux tests deterministic.

    @jdswinbank @laurenam
    jdswinbank authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    532b55d View commit details
    Browse the repository at this point in the history

  4. Make NoiseReplacer tests deterministic.

    @jdswinbank @laurenam
    jdswinbank authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    67c5174 View commit details
    Browse the repository at this point in the history

  5. Rename TestDataset class on import to avoid confusion 

    pytest looks for classes starting with "Test" and will complain
about being unable to find any tests. Renaming the class on
import avoids this problem.
    @timj @laurenam
    timj authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    7c29596 View commit details
    Browse the repository at this point in the history

  6. Write "1 source" not "1 sources" in log

    @timj @laurenam
    timj authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    e64cebe View commit details
    Browse the repository at this point in the history

  7. Fix flake8 warnings in SConscript files

    @timj @laurenam
    timj authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    75a4b87 View commit details
    Browse the repository at this point in the history

  8. Enable pytest auto test discovery

    @timj @laurenam
    timj authored and laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    84e67e0 View commit details
    Browse the repository at this point in the history

  9. Make all test dataset realization deterministic 

    Some tests here depend on the noise realization in the test data
or from the numpy random number generator, so we seed all dataset
realizations explicitly.  For the current test data and seed value
of the random number seed (chosen solely based on the "test passes"
criterion), they pass.  This may no longer be true if the test data
is regenerated or the seed value is changed.
    @laurenam
    laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    bc0dbfe View commit details
    Browse the repository at this point in the history

  10. Remove random seeding from test utilities 

    Random seeding is now done explicitly in the unittests, so this is
no longer used.
    @laurenam
    laurenam committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    f1da33d View commit details
    Browse the repository at this point in the history